Fix escaping of dollar symbols in HTMLWriter #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Javascript LaTeX engines got confused trying to distinguish between inline delimiters and dollar symbols for actual currency. This works around the problem by wrapping (currency) dollar symbols in a span tag.
mortenpi
reviewed
Jul 4, 2021
mortenpi
approved these changes
Jul 4, 2021
There was a problem hiding this comment.
LGTM, I think this is a clever workaround. And doesn't have the potentially breaking aspect of changing the delimiter configuration.
We don't really have good integration tests of the outputs. The best we do currently are the occursins in the example builds. Potentially you could add a few tests there -- I think having your snippet in the test/examples build would be good.
Just a passing thought, beyond the scope of this PR, but in the future we could use Gumbo to parse the generated HTML and then do some sanity checks on the AST. It worked well for generating the outdated version warnings.
|
@mortenpi how's this? |
|
Looks good @odow, thanks! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Javascript LaTeX engines got confused trying to
distinguish between inline delimiters and dollar symbols for actual
currency. This works around the problem by wrapping (currency) dollar
symbols in a span tag.
Closes #890
I could use come pointers on how to test this properly. (Is there a way to test the output of the rendered HTML?) I got confused with the structure of
/test. Here's my more-involved local test: